Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration test for Google GCS hosted table #105

Merged
merged 26 commits into from
Jan 11, 2022

Conversation

zhuansunxt
Copy link
Collaborator

  • Integration test.
  • Library version upgrade. The previous version has bug when reading the file content.

The python integration test does not work yet. Still looking.

Copy link
Member

@zsxwing zsxwing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

README.md Show resolved Hide resolved
@zhuansunxt
Copy link
Collaborator Author

Added.

  • For the test, I think we also need to write code to generate the file that GOOGLE_APPLICATION_CREDENTIALS points to.

Why can not we just setup the file path?

@zsxwing
Copy link
Member

zsxwing commented Jan 10, 2022

Why can not we just setup the file path?

GitHub Actions runs in a container, but we don't want to build a public docker image that includes the google key file. To be clear, I meant the following steps:

  • Store the key file content in GitHub secrets.
  • Add GOOGLE_APPLICATION_CREDENTIALS to point to a file path, such as /tmp/google_key.json.
  • Read the key file content from env and write it into the file /tmp/google_key.json.

@zhuansunxt
Copy link
Collaborator Author

@zsxwing I added code to write temp file with key body loaded from github secret in integration test and it is verified to work (see https://github.com/delta-io/delta-sharing/tree/integration-test). However there is another issue of "Type[URL]" has no attribute "_PATH_REQUOTER" in the Github Action even if yarl is installed with desirable version (tried both 1.6.0 and 1.7.2).

@zsxwing
Copy link
Member

zsxwing commented Jan 11, 2022

However there is another issue of "Type[URL]" has no attribute "_PATH_REQUOTER" in the Github Action even if yarl is installed with desirable version (tried both 1.6.0 and 1.7.2).

We can ignore the mypy check error by adding a comment like this:

URL._PATH_REQUOTER = _Quoter(safe="@:", protected="/+=")  # type: ignore

Copy link
Member

@zsxwing zsxwing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some minor style comments. Otherwise LGTM

python/requirements-dev.txt Outdated Show resolved Hide resolved
python/setup.py Outdated Show resolved Hide resolved
@zhuansunxt
Copy link
Collaborator Author

@zsxwing All comments addressed and integration tests are running correctly for server, spark and python client. Please take a final look.

Copy link
Member

@zsxwing zsxwing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhuansunxt zhuansunxt merged commit eb0e5bd into delta-io:main Jan 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants