Fix GCS path parsing #181
Merged
Fix GCS path parsing #181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zsxwing
commented
Aug 25, 2022
| assert(objectName.nonEmpty, s"cannot get object key from $path") | ||
| val blobInfo = BlobInfo.newBuilder(BlobId.of(bucketName, objectName)).build | ||
| storage.signUrl( | ||
| blobInfo, preSignedUrlTimeoutSeconds, SECONDS, Storage.SignUrlOption.withV4Signature()) | ||
| .toString | ||
| } | ||
| } | ||
|
|
||
| object GCSFileSigner { | ||
| def getBucketAndObjectNames(path: Path): (String, String) = { |
There was a problem hiding this comment.
Create a new method for this so that I can write tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For a path such as
gs://delta_sharing_test/foo,getHostwill return null and trigger NPE. This PR changes the code to call GCS APIs to parse a path instead to avoid such issue (It callsgetAuthorityunderlying instead).This is not an issue for S3 or Azure because they do require the bucket name to be a valid host name (cannot contain
_).