Support timestamp in table query request in oss delta sharing server #186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chakankardb
approved these changes
Sep 23, 2022
| throw new DeltaSharingIllegalArgumentException("Reading table by version is not supported" + | ||
| s" because change data feed is not enabled on table: $share.$schema.$table") | ||
| throw new DeltaSharingIllegalArgumentException("Reading table by version or timestamp is" + | ||
| " not supported because change data feed is not enabled on table: " + |
There was a problem hiding this comment.
Question: With streaming, we will allow time travel queries even if cdf is not enabled... right?
There was a problem hiding this comment.
Yes. We'll have another field to guard this, pending on the decision about default behavior change.
server/src/main/scala/io/delta/standalone/internal/DeltaSharedTableLoader.scala
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support timestamp in table query request in oss delta sharing server, only one of timestamp and version is supported, and they are only supported when cdfEnabled is true.