Support delta-sharing-capabilities header in DeltaSharingRestClient #338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@wchau Can you please also look at this change? |
chakankardb
reviewed
Jul 20, 2023
| val (version, lines) = getNDJson(target) | ||
| val (version, respondedFormat, lines) = getNDJson(target) | ||
| if (responseFormat != respondedFormat) { | ||
| logWarning(s"RespondedFormat($respondedFormat) is different from requested responseFormat(" + |
There was a problem hiding this comment.
Perhaps add a comment that this can happen if the DS server does not support the requested format.
Ideally, this should only happen if we request delta format but get back parquet. The reverse is not expected right?
There was a problem hiding this comment.
Right!
And this happens on the two recipient on uc use cases, where the delta sharing server is an open servers, and recipients are on databricks DBR, so recipients would any way use this code to ask for "delta" format, but may get parquet in response. And we should still be able to handle that case.
chakankardb
approved these changes
Jul 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support delta-sharing-capabilities header in DeltaSharingRestClient, if
responseFormat=delta, then we don't parse the returned lines, just return them as a Seq[String]. In the tests, we are still trying to check the returned fields by directly matching the string.For tests on exceptions, we use
DeltaSharingRestClientSuiteas the responseFormat shouldn't matter. For tests with successfully returned rpcs, we add a newDeltaSharingRestClientDeltaSuiteto check the returned lines.Please only review the changes under
client/in this PR, changes underserver/should be reviewed with #335.This is part 2 for issue #341
TODO: check whether what we should do with random capabilities header, error or ignore.