Enhance protocol documentation #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zsxwing
reviewed
Nov 29, 2021
|
I think the change overall looks pretty good. Two suggestions:
|
wchau
force-pushed
the
documentation
branch
3 times, most recently
from
e0a9ec4
to
77a849f
Compare
Done. See #98
I am creating a poor man's version of DB's official API docs which follows the same format to try to be somewhat consistent. eg: https://docs.databricks.com/dev-tools/api/latest/account.html#operation/get-credential-configs |
linzhou-db
reviewed
Dec 23, 2021
There was a problem hiding this comment.
Overall LGTM, do we also want to cover the status code in the http response?
NVM, see #98
linzhou-db
approved these changes
Dec 23, 2021
…Results, and nextPageToken details Added response codes. Fixed formatting. Identified int types. Change error_code to errorCode ID Details ID Drop details Summary 200
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added edge case details with non-negative and 0 max results, and existence of page token.
Fixed JSON formatting.
Identified int types.
https://github.com/delta-io/delta-sharing/blob/c44815eb6b1984e59216e9b7e88b3eeb1b7631db/PROTOCOL.md