You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently, the DELETE operation returns an empty result. It would be more useful if it returned the number of deleted rows.
Motivation
The number of deleted rows is an obvious metric that users would want from a delete operation.
Further details
Currently, DeleteCommand.scala is explicitly returning an empty DataFramehere. Instead, we could use the metrics member field to return the numDeletedRows.
Make sure to add tests, too :)
The text was updated successfully, but these errors were encountered:
Hi @AhmedEHaddad - I believe so. Do you propose another way? Internally, regardless of SQL or DataFrame API, Delta Lake will eventually end up using DeleteCommand.scala to implement the delete operation.
@scottsand-db I had a look at the RunnableCommand and I hadn't grasped the meaning of the returned row. If I understood it correctly, this change should be sufficient.
I wanted to get feedback around the design before adding the tests, I hadn't opened a PR yet for this reason. It's my first contribution, so rather than implementing tests for the wrong thing, I wanted to double check if I understood the API
Feature request
Overview
Currently, the
DELETE
operation returns an empty result. It would be more useful if it returned the number of deleted rows.Motivation
The number of deleted rows is an obvious metric that users would want from a delete operation.
Further details
Currently,
DeleteCommand.scala
is explicitly returning an emptyDataFrame
here. Instead, we could use themetrics
member field to return thenumDeletedRows
.Make sure to add tests, too :)
The text was updated successfully, but these errors were encountered: