[1222] Make DELETE command return the number of deleted rows #1328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- update DelteMetricSuite tests - add explicit test for delete along partition boundary
edmondop
reviewed
Aug 10, 2022
core/src/main/scala/org/apache/spark/sql/delta/commands/DeleteCommand.scala
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR makes the
DELETEcommand in Delta Lake return the numAffectedRows metric.How was this patch tested?
Updated tests inside of
DeleteMetricsSuitewhich now test fornumAffectedRows. I also added a test to check explicitly for the case of deletes along partition boundaries.Does this PR introduce any user-facing changes?
Yes. Deletes will now return the number of deleted rows.
For example,
will now return a DataFrame with one row with column
num_affected_rowsof type Long.Resolves #1222