-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PROTOCOL RFC] Add TIME
& INTERVAL
as supported dtypes
#2827
Comments
Supersedes this issue: #2319 |
TIME
& INTERVAL
as support dtypes in protocolTIME
& INTERVAL
as supported dtypes in protocol
TIME
& INTERVAL
as supported dtypes in protocolTIME
& INTERVAL
as supported dtypes in protocol
TIME
& INTERVAL
as supported dtypes in protocolTIME
& INTERVAL
as supported dtypes
TIME
& INTERVAL
as supported dtypesTIME
& INTERVAL
as supported dtypes
This makes sense to me if it's just like TimestampNTZ. It's unfortunate that Spark doesn't have a TIME type (yet). :/ |
@bart-samwel what would be the next steps to make this happen? |
Seems like we need to add the datatype support to spark, as a starting point? |
Can we maybe start with interval first then, since it's supported in all engines? I can add the support in delta-kernel-rs and Delta-RS for both types |
@scovich @tdas @ryan-johnson-databricks and @bart-samwel Can we move forward with this adding it to the protocol? @scovich I don't see why we should at this to Spark first |
I am often getting the question, why doesn't delta-rs support time/interval dtypes.. Seems obvious to add since it's supported by Parquet and supported by most engines.
We can do the same thing as timestampNtz and gate these behind a reader & writer feature. I am proposing we add these primitive types:
TimeType
) https://github.com/apache/parquet-format/blob/master/LogicalTypes.md#timeTime
This feature introduces a new data type to support
time
. For example:00:00:00, or 24:00:00.
The serialization method would be:{hour}:{minute}:{second}
Interval
This feature introduces a new data type to support day-time
interval
s. For example:5d 10h 5m 10s
. The serialization method would be:{day}d:{hour}h:{minute}m:{second}s
To support these feature:
To have a column of Time/Interval type in a table, the table must have Reader Version 3 and Writer Version 7. A feature name time/interval must exist in the table's readerFeatures and writerFeatures.
Engine support:
The text was updated successfully, but these errors were encountered: