Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass the SparkSession when resolving the tables in the DeltaTableBuilder #1476

Conversation

moredatapls
Copy link
Contributor

@moredatapls moredatapls commented Nov 4, 2022

Signed-off-by: Helge Bruegner helge@bruegner.de

Description

  • Forward the SparkSession when resolving the tables in the DeltaTableBuilder
  • Remove some unused imports

Resolves #1475

How was this patch tested?

/

Does this PR introduce any user-facing changes?

No.

Signed-off-by: Helge Bruegner <helge@bruegner.de>
Signed-off-by: Helge Bruegner <helge@bruegner.de>
@moredatapls
Copy link
Contributor Author

I would need some guidance regarding the testing: is there any test I could add or is this covered already?

@zsxwing
Copy link
Member

zsxwing commented Nov 8, 2022

I would need some guidance regarding the testing: is there any test I could add or is this covered already?

It's fine to not add a test for this trivial change.

@moredatapls moredatapls marked this pull request as ready for review November 8, 2022 21:09
@moredatapls moredatapls changed the title [WIP] Pass the SparkSession when resolving the tables in the DeltaTableBuilder Pass the SparkSession when resolving the tables in the DeltaTableBuilder Nov 8, 2022
Copy link
Member

@zsxwing zsxwing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@vkorukanti vkorukanti added this to the 2.2.0 milestone Dec 5, 2022
vkorukanti pushed a commit to vkorukanti/delta that referenced this pull request Jan 5, 2023
(Cherry-pick 68c8e18 to branch-2.0)

Signed-off-by: Helge Bruegner <helge@bruegner.de>

- Forward the SparkSession when resolving the tables in the DeltaTableBuilder
- Remove some unused imports

Resolves delta-io#1475

/

No.

Closes delta-io#1476

Signed-off-by: Shixiong Zhu <zsxwing@gmail.com>
GitOrigin-RevId: 880de0f55ee79289cecd19d74c4c177c76d30aeb
vkorukanti pushed a commit to vkorukanti/delta that referenced this pull request Jan 6, 2023
(Cherry-pick 68c8e18 to branch-2.0)

Signed-off-by: Helge Bruegner <helge@bruegner.de>

- Forward the SparkSession when resolving the tables in the DeltaTableBuilder
- Remove some unused imports

Resolves delta-io#1475

/

No.

Closes delta-io#1476

Signed-off-by: Shixiong Zhu <zsxwing@gmail.com>
GitOrigin-RevId: 880de0f55ee79289cecd19d74c4c177c76d30aeb
vkorukanti pushed a commit that referenced this pull request Jan 24, 2023
(Cherry-pick 68c8e18 to branch-2.1)

Signed-off-by: Helge Bruegner <helge@bruegner.de>

- Forward the SparkSession when resolving the tables in the DeltaTableBuilder
- Remove some unused imports

Resolves #1475

/

No.

Closes #1476

Signed-off-by: Shixiong Zhu <zsxwing@gmail.com>
GitOrigin-RevId: 880de0f55ee79289cecd19d74c4c177c76d30aeb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] DeltaTableBuilder.execute() sometimes throws "Could not find active SparkSession"
3 participants