Automatically generate partition filters for generated columns using the trunc date function #1513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…for generated columns using trunc function. Signed-off-by: brayan_jules <brayan_jules@epam.com>
…ime,date,str) that could be sent to a trunc function. Signed-off-by: brayan_jules <brayan_jules@epam.com>
Signed-off-by: brayan_jules <brayan_jules@epam.com>
core/src/main/scala/org/apache/spark/sql/delta/GeneratedColumn.scala
Outdated
Show resolved
Hide resolved
core/src/main/scala/org/apache/spark/sql/delta/GeneratedColumn.scala
Outdated
Show resolved
Hide resolved
core/src/main/scala/org/apache/spark/sql/delta/optimizablePartitionExpressions.scala
Show resolved
Hide resolved
Signed-off-by: brayan_jules <brayan_jules@epam.com>
Signed-off-by: Brayan Jules <brayan1213@gmail.com> Signed-off-by: brayan_jules <brayan_jules@epam.com>
|
@brayanjuls Do you have an email address I can use to sign the commit? Thanks |
|
@allisonport-db - yes, you can use brayan1213@gmail.com |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We are adding support for partition filter on partition columns that use the generation expression trunc date. We are considering the following data filters:
Because the date resolution of the partition column has truncated information, we need to reuse the implementation of the following functions:
This PR resolves issue #1446
How was this patch tested?
I added three new tests to the OptimizeGeneratedColumnSuite class.
Does this PR introduce any user-facing changes?
No