Protocol Specification for Row Commit Versions #1747
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bart-samwel
approved these changes
May 9, 2023
allisonport-db
pushed a commit
that referenced
this pull request
May 30, 2023
This PR implements part of the changes proposed in #1747. It adds the `defaultRowCommitVersion` field to `AddFile` and `RemoveFile`, and it makes sure that it's populated during commits and read during log replay. It **does not** handle any transaction conflicts yet. Closes #1781 GitOrigin-RevId: 781617fd33b3be2f39ac8ab36aa0b741ba99c97e
8 tasks
tdas
pushed a commit
that referenced
this pull request
Nov 14, 2023
## Description This PR fixes a terminology issue in Delta protocol, so the term `supported` is now used to describe a table feature name being listed in table protocol's `readerFeatures` and/or `writerFeatures`. The choice of this word is to emphasize that, in such a scenario, the Delta table *may* use the listed table features but is not forced to do so. For example, when `appendOnly` is listed in a table's protocol, the table may or may not be append-only, depending on the existence and value of table property `delta.appendOnly`. However, writers must recognize the table feature `appendOnly` and know that the table property should be checked before writing this table. This PR did not touch the Row ID/Row Tracking sections, as it's handled by another PR: #1747. Closes #1780 Co-authored-by: Lars Kroll <lars.kroll@databricks.com> Co-authored-by: Bart Samwel <bart.samwel@databricks.com> Signed-off-by: Paddy Xu <xupaddy@gmail.com> GitOrigin-RevId: 8d9b86262e91a88a85388c6333c5ef7ac296931e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the protocol specification changes for the Row Commit Versions that are proposed #1715.
In particular it makes the following changes:
rowIdsfeature torowTracking.delta.enableRowIdsproperty todelta.enableRowTracking.preservedRowIdsflag inrowIdHighWaterMarktodelta.rowTracking.preservedin thetagsofcommitInfo.How was this patch tested?
n/a
Does this PR introduce any user-facing changes?
n/a