Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Spark] Add Writer Protocol check in Vacuum Command #2558

Merged
merged 2 commits into from Jan 23, 2024

Conversation

prakharjain09
Copy link
Collaborator

@prakharjain09 prakharjain09 commented Jan 22, 2024

Which Delta project/connector is this regarding?

  • Spark
  • Standalone
  • Flink
  • Kernel
  • Other (fill in here)

Description

(Cherry-pick of #2557 to branch-3.1)

This PR adds Write PROTOCOL check to the Vacuum Command since it makes changes to delta directory.

How was this patch tested?

UTs

Does this PR introduce any user-facing changes?

No

Copy link
Contributor

@tdas tdas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for backporting. This will be good to get out as quickly as possible. It does not make sense of any protocol implementation to be able to vacuum a table if you cant really write to that table.

@vkorukanti vkorukanti merged commit 559d1f8 into delta-io:branch-3.1 Jan 23, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants