[Kernel][Expressions] Adds the IS_NULL expressions #2651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tai Le Manh <manhtai.lmt@gmail.com>
Signed-off-by: Tai Le Manh <manhtai.lmt@gmail.com>
# Conflicts: # kernel/kernel-defaults/src/test/scala/io/delta/kernel/defaults/internal/expressions/DefaultExpressionEvaluatorSuite.scala
vkorukanti
requested changes
Feb 18, 2024
| * <li>Name: <code>IS_NULL</code> | ||
| * <ul> | ||
| * <li>SQL semantic: <code>expr IS NULL</code></li> | ||
| * <li>Since version: 3.1.0</li> |
There was a problem hiding this comment.
Suggested change
| * <li>Since version: 3.1.0</li> | |
| * <li>Since version: 3.2.0</li> |
There was a problem hiding this comment.
This will go in next release version 3.2.0
| @@ -232,6 +232,15 @@ ExpressionTransformResult visitIsNotNull(Predicate predicate) { | |||
| ); | |||
| } | |||
|
|
|||
| @Override | |||
| ExpressionTransformResult visitIsNull(Predicate predicate) { | |||
| Expression child = visit(predicate.getChildren().get(0)).expression; | |||
There was a problem hiding this comment.
Suggested change
| Expression child = visit(predicate.getChildren().get(0)).expression; | |
| Expression child = visit(getUnaryChild(predicate)).expression; |
| @@ -513,6 +522,16 @@ ColumnVector visitIsNotNull(Predicate predicate) { | |||
| ); | |||
| } | |||
|
|
|||
| @Override | |||
| ColumnVector visitIsNull(Predicate predicate) { | |||
| ColumnVector childResult = visit(childAt(predicate, 0)); | |||
There was a problem hiding this comment.
Suggested change
| ColumnVector childResult = visit(childAt(predicate, 0)); | |
| ColumnVector childResult = visit(getUnaryChild(predicate)); |
@vkorukanti TYSM, I have resolved it. |
vkorukanti
approved these changes
Feb 19, 2024
8 tasks
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which Delta project/connector is this regarding?
Description
Resolve #2632. Adds the IS NULL expressions.
How was this patch tested?
Adds unit test.