[Kernel] Use LogStores in listFrom implementation in default FileSystemClient
#2770
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...rnel-defaults/src/main/java/io/delta/kernel/defaults/internal/logstore/LogStoreProvider.java
Outdated
Show resolved
Hide resolved
|
|
||
| /** | ||
| * Get the {@link LogStore} instance for the given schema and configuration. Callers can set | ||
| * {code io.delta.kernel.logStore.class} to specify the LogStore implementation to use. If not |
There was a problem hiding this comment.
why support both io.delta.kernel.logStore.class and io.delta.kernel.logStore.<scheme>.impl?
There was a problem hiding this comment.
This should be io.delta.kernel.logStore.<scheme>.impl. Updated the javadoc
scottsand-db
approved these changes
Mar 21, 2024
This was referenced Mar 21, 2024
vkorukanti
added a commit
that referenced
this pull request
Mar 21, 2024
## Description Prep for #2770 PR
vkorukanti
added a commit
that referenced
this pull request
Mar 22, 2024
## Description Build changes from PR: #2770
vkorukanti
force-pushed
the
useLogStoreListFrom
branch
from
1e6a1c0
to
c5b22ca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
LogStores instoragemodule have file system operations (needed for reading/writing DeltaLogs) implemented for each storage (e.g. s3, GCS etc.) to take into account of the behavior of storage and also efficiently implement certain operations depending upon the storage system support (e.g. fast listing in S3).This PR creates
LogStoreProviderto get the specific implementation of theLogStorefor givenscheme. Also updates theDefaultFileSystemClient.listFromto use theLogStore.listFrom.The majority of the code here is copied from the
delta-sparkandstandaloneprojects.How was this patch tested?
Unittests for
LogStoreProviderand existing integration tests forDefaultFileSystemClient.listFromchanges.