[Kernel] Retry _last_checkpoint loading in case of failures
#2812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
-107
to
+123
| return checkpointRow.map(CheckpointMetaData::fromRow); | ||
| if (checkpointRow.isPresent()) { | ||
| return Optional.of(CheckpointMetaData.fromRow(checkpointRow.get())); | ||
| } |
There was a problem hiding this comment.
what's the logical difference between these two diffs?
Comment on lines
141
to
143
| String msg = String.format("Failed to load checkpoint metadata from file %s. " + | ||
| "Retrying after 1sec. (current attempt = %s)", | ||
| lastCheckpointFilePath, tries); |
There was a problem hiding this comment.
nit: weird formatting / indentation
scottsand-db
approved these changes
Mar 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, Kernel stops on first failure at loading the
_last_checkpointfile (which contains info about the last checkpoint). We should have mechanisms to retry just like how Delta-Spark retries on retryable failures. More details are here.How was this patch tested?
Added mock unittests
Does this PR introduce any user-facing changes?