[Kernel] Add support for reading tables with timestamp_ntz type columns
#2855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vkorukanti
changed the title
timestamp_ntz type columnstimestamp_ntz type columns
scottsand-db
approved these changes
Apr 6, 2024
| @@ -86,6 +86,9 @@ public long getLong(int rowId) { | |||
| } else if (partitionType.equivalent(TimestampType.TIMESTAMP)) { | |||
| return InternalUtils.microsSinceEpoch( | |||
| Timestamp.valueOf(input.getString(rowId))); | |||
| } else if (partitionType.equivalent(TimestampNTZType.TIMESTAMP_NTZ)) { | |||
There was a problem hiding this comment.
minor nit: might be safer to do
else if (partitionType.equivalent(TimestampType.TIMESTAMP) ||
partitionType.equivalent(TimestampNTZType.TIMESTAMP_NTZ))) {
return InternalUtils.microsSinceEpoch(
Timestamp.valueOf(input.getString(rowId)));
}then one implementation won't accidentally diverge from the other in the future
| @@ -77,7 +79,9 @@ public static Converter createConverter( | |||
| return DecimalColumnReader.createDecimalConverter( | |||
| initialBatchSize, (DecimalType) typeFromClient, typeFromFile); | |||
| } else if (typeFromClient instanceof TimestampType) { | |||
| return TimestampConverters.createTimestampConverter(initialBatchSize, typeFromFile); | |||
There was a problem hiding this comment.
updated the other one. This one has different method calls depending upon the type.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #2279