Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Spark] Add IdentityColumnsTableFeature #2859

Merged
merged 2 commits into from
Apr 11, 2024

Conversation

c27kwan
Copy link
Contributor

@c27kwan c27kwan commented Apr 8, 2024

Which Delta project/connector is this regarding?

  • Spark
  • Standalone
  • Flink
  • Kernel
  • Other (fill in here)

Description

This PR is part of #1959

In this PR, we introduce the IdentityColumnsTableFeature to test-only so that we can start developing with it.

Note, we do not add support to minWriterVersion 6 yet to properties.defaults.minWriterVersion because that will enable the table feature outside of testing.

How was this patch tested?

Existing tests pass.

Does this PR introduce any user-facing changes?

No, this is a test-only change.

@c27kwan c27kwan changed the title [Spark] Add IdentityColumnTableFeature [Spark] Add IdentityColumnsTableFeature Apr 8, 2024
Copy link
Contributor

@xupefei xupefei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@vkorukanti vkorukanti merged commit 3bf9704 into delta-io:master Apr 11, 2024
7 checks passed
andreaschat-db pushed a commit to andreaschat-db/delta that referenced this pull request Apr 16, 2024
## Description
This PR is part of delta-io#1959

In this PR, we introduce the IdentityColumnsTableFeature to test-only so
that we can start developing with it.

Note, we do not add support to minWriterVersion 6 yet to
properties.defaults.minWriterVersion because that will enable the table
feature outside of testing.

## How was this patch tested?
Existing tests pass. 

## Does this PR introduce _any_ user-facing changes?
No, this is a test-only change.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants