[Flink][WIP] Support using with Flink 1.18 #2871
Open
+47
−115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds the relatively minor changes required to support Flink 1.18 - Calcite has a new version of Janino that breaks API - The newer Flink Hive catalog has some new more specific type requirements internally Signed-off-by: Aurora Nockert <aurora@nockert.se>
This commit most likely should not exist, the breakage is just in the internal namespace but I have no idea how to signal to Mima that this is not an actual API breakage. Signed-off-by: Aurora Nockert <aurora@nockert.se>
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which Delta project/connector is this regarding?
Description
This adds changes to support using Delta with Flink 1.18.
Work in progress
io.delta.flink.internalare actually exposed API.I think these should be done as separate PRs but I am not sure, depending on what you think I'll either do another PR for the Mima things or fix it properly in here.
How was this patch tested?
It was tested via the test suite (on Java 8, running on arm64 macOS) and some minor manual testing.
If you have any ideas on how to better test this I would love to know, since I think I can see a patch to support Flink 1.19 in my future and would love to be more confident in that one.
Does this PR introduce any user-facing changes?
No. It should not beyond supporting a newer version of Flink.
Thanks
Thanks to @sdahlbac and @oskarskog for helping me with this, I definitely would not have had the patience to run the test suite this many without them.