[Kernel] Push predicate on partition values to checkpoint reader in state reconstruction #2872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vkorukanti
changed the title
vkorukanti
force-pushed
the
checkpointPredicatePushdown
branch
from
ff8e50a
to
8fd5440
Compare
kernel/kernel-api/src/main/java/io/delta/kernel/internal/util/PartitionUtils.java
Outdated
Show resolved
Hide resolved
| * checkpoint files. | ||
| * | ||
| * @param predicate Predicate on partition columns. | ||
| * @param partitionColMetadata Map of partition column name (in lower case) to its type. |
There was a problem hiding this comment.
to its type --> do we only need the type? like DataType? Or do we need the entire structfield?
There was a problem hiding this comment.
I see we want the StructField. Could we replace to its type with to its StructField?
scottsand-db
approved these changes
Apr 10, 2024
vkorukanti
force-pushed
the
checkpointPredicatePushdown
branch
from
c3c06c5
to
773775b
Compare
andreaschat-db
pushed a commit
to andreaschat-db/delta
that referenced
this pull request
Apr 16, 2024
…tate reconstruction (delta-io#2872) ## Description Converts the partition predicate into a filter on `add.partitionValues_parsed.<partitionPhysicalColName>`. This predicate is pushed to the Parquet reader when reading the checkpoint files during the state reconstruction. This helps prune reading checkpoint files that can't possibly have any scan files satisfying the given partition predicate. This can be extended in future to even support pushdown of predicate on data columns as well. ## How was this patch tested? Unittests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Converts the partition predicate into a filter on
add.partitionValues_parsed.<partitionPhysicalColName>. This predicate is pushed to the Parquet reader when reading the checkpoint files during the state reconstruction. This helps prune reading checkpoint files that can't possibly have any scan files satisfying the given partition predicate.This can be extended in future to even support pushdown of predicate on data columns as well.
How was this patch tested?
Unittests