[Spark] Add Preserving Row Tracking in Update #2927
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
longvu-db
force-pushed
the
stack/preserve-row-tracking-update
branch
from
fbe91d4
to
867025e
Compare
johanl-db
reviewed
Apr 22, 2024
| @@ -234,5 +234,4 @@ trait RowIdTestUtils extends RowTrackingTestUtils with DeltaSQLCommandTest with | |||
| def checkRowTrackingMarkedAsPreservedForCommit(log: DeltaLog)(operation: => Unit): Unit = { | |||
| assert(rowTrackingMarkedAsPreservedForCommit(log)(operation)) | |||
| } | |||
|
|
|||
| } | |||
There was a problem hiding this comment.
nit: undo this spurious change
There was a problem hiding this comment.
@johanl-db Why not? I think it's worth doing as I added that by mistake in the Preserve Delete PR.
spark/src/test/scala/org/apache/spark/sql/delta/rowid/RowTrackingUpdateSuite.scala
Show resolved
Hide resolved
spark/src/test/scala/org/apache/spark/sql/delta/rowid/RowTrackingUpdateSuite.scala
Show resolved
Hide resolved
spark/src/test/scala/org/apache/spark/sql/delta/rowid/RowTrackingUpdateSuite.scala
Show resolved
Hide resolved
tdas
approved these changes
Apr 22, 2024
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which Delta project/connector is this regarding?
Description
Preserve row IDs in UPDATE by reading the metadata column and writing it out to the physical column.
How was this patch tested?
Added UTs.
Does this PR introduce any user-facing changes?
No.