[Spark] Makes CommitOwnerClient independent of Delta Spark dependencies #3002
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| /** | ||
| * We expect the Protocol action to have the same fields as AbstractProtocol (part of the | ||
| * CommitStore interface). With this if any change has happened in the Protocol of the table, |
There was a problem hiding this comment.
CommitStore has been replaced with Commit owner / ComitOwnerClient -- depending on the context in the entire code/comments. Could we follow the same convention here as well.
There was a problem hiding this comment.
Updated to reflect the new naming.
prakharjain09
approved these changes
May 1, 2024
5 tasks
scottsand-db
pushed a commit
that referenced
this pull request
May 7, 2024
…duces getters (#3033) #### Which Delta project/connector is this regarding? - [x] Spark - [ ] Standalone - [ ] Flink - [ ] Kernel - [ ] Other (fill in here) ## Description This is the second PR in a series of PRs to move the current CommitOwner interface to its own module. PR1 is [here](#3002). This PR makes the fields of all CommitOwner-related classes private and forces callers to use getters to access the fields. This is needed in preparation for making the CommitOwner module a Java module (the same as the existing LogStore module) and to follow Java best practices to keep fields private and only allow access through getters. ## How was this patch tested? Simple refactor so existing tests are sufficient. ## Does this PR introduce _any_ user-facing changes? No
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which Delta project/connector is this regarding?
Description
This PR is the first in a series of PRs that refactors the current CommitOwnerClient interface to become its own module. This is similar to
storagemodule that currently exists and contains the LogStore interface and its implementations. In this PR, we remove any Delta Spark dependencies from the CommitOwnerClient in preparation for it to be moved outside of Delta Spark.How was this patch tested?
Added tests to check equivalence of newly introduced AbstractProtocol/AbstractMetadata with Protocol/Metadata.
Does this PR introduce any user-facing changes?
No