Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Spark][3.2] Fix dropping type widening feature with multipart identifiers #3036

Conversation

johanl-db
Copy link
Collaborator

Description

Fix an issue found while testing the Delta 3.2 RC2:
Dropping the type widening table feature may fail parsing the table identifier:

ALTER TABLE default.type_widening_int DROP FEATURE 'typeWidening-preview' TRUNCATE HISTORY;

[PARSE_SYNTAX_ERROR] Syntax error at or near '.'.(line 1, pos 21)

== SQL ==
spark_catalog.default.type_widening_int

Parsing the table identifier isn't needed as it's not used by the REORG operation that rewrite files when dropping the feature. This change skip parsing the table identifier and directly passes the table name to the REORG command

How was this patch tested?

Added test covering the issue

@johanl-db johanl-db self-assigned this May 3, 2024
@johanl-db johanl-db added this to the 3.2.0 milestone May 3, 2024
Copy link
Contributor

@sabir-akhadov sabir-akhadov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@scottsand-db scottsand-db merged commit d68c54e into delta-io:branch-3.2 May 3, 2024
7 checks passed
scottsand-db pushed a commit that referenced this pull request May 6, 2024
Cherry-pick of #3036 to `master`

## Description
Add a documentation page for the type widening table feature, in preview
in Delta. 3.2

## How was this patch tested?
N/A
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants