[Spark] Only attempt parsing partition path into different types if type inference is enabled #3374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amogh-jahagirdar
changed the title
amogh-jahagirdar
changed the title
amogh-jahagirdar
changed the title
amogh-jahagirdar
changed the title
4 tasks
spark/src/main/scala/org/apache/spark/sql/delta/util/PartitionUtils.scala
Outdated
Show resolved
Hide resolved
spark/src/main/scala/org/apache/spark/sql/delta/util/PartitionUtils.scala
Outdated
Show resolved
Hide resolved
amogh-jahagirdar
force-pushed
the
partition-type-inference-cleanup
branch
from
60d2292
to
327fd9f
Compare
…f type inference is disabled
amogh-jahagirdar
force-pushed
the
partition-type-inference-cleanup
branch
from
327fd9f
to
85816d2
Compare
scottsand-db
approved these changes
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which Delta project/connector is this regarding?
Description
I was looking at this code path for another issue and noticed that when parsing partition values from paths (only used for the write path) without type inference we still attempt to due parsing for date/decima/timestamp types even though it's not required. We can avoid that work with a small refactoring.
How was this patch tested?
This is a refactoring/minor optimization where existing unit tests will exercise this path
Does this PR introduce any user-facing changes?
No