Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4 added fixes and new features #234

Merged
merged 56 commits into from
Feb 22, 2023
Merged

4 added fixes and new features #234

merged 56 commits into from
Feb 22, 2023

Conversation

dev-smart-ui
Copy link
Contributor

Hey folks! Here the next updates:

  1. Added form as html file. You can see it on the url “/form.html”. You can add query params (as I see, the offer_code) and use it. It works.

  2. Changed the “Contributor of the month” section and added Gerhard’s profile. Changed a list so you would link to the personal profile.

  3. I created my own Youtube channel to test the error of the building process when you created the scheduled video. I created a lot of scheduled videos in different variations but I didn't catch errors. So, please let me know when you catch errors with your building process and I would explore it.

  4. Added aligning the thumbnails, added the logos for the sections.

  5. Added the script for Hubspot chat. As I know you need to set up the chat through your personal profile on Hubspot. Chat is working, I tested it on my own Hubspot profile.

  6. Remove duplicate videos on the community page.

PS. Sorry, sometimes I see someone from your team tries to add updates to our fork of your repository. This is a bad idea because all these changes will not show up on your site. And before I start working, I need to synchronize this fork with your repository and I need to cancel all other commits in our fork. That's how it works.

@netlify
Copy link

netlify bot commented Feb 14, 2023

Deploy Preview for delta-io-beta ready!

Name Link
🔨 Latest commit c4a5fbe
🔍 Latest deploy log https://app.netlify.com/sites/delta-io-beta/deploys/63f540339584c1000779cc8b
😎 Deploy Preview https://deploy-preview-234--delta-io-beta.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@dennyglee
Copy link
Collaborator

Thanks for all the great work - had some requested fixes:

Home/Integrations page

  • Could you update it so that the Delta Lake logo is added to only the Integrations page, not the home page?
  • Please use the Delta Logo with the transparent background, you can find them here

For the videos page

  • Extra vertical spacing between "Watch the latest videos and webinars for the open-source Delta Lake project." and "Last Week in a Byte"
  • Could you make the video headers (e.g. "Last Week in a Byte") larger (i.e., an actual header)

Thanks!

@dev-smart-ui
Copy link
Contributor Author

Extra vertical spacing between "Watch the latest videos and webinars for the open-source Delta Lake project." and "Last Week in a Byte"
....
Sorry, could you clarify we need to add or remove extra spacing?

@dennyglee
Copy link
Collaborator

Oh sorry, hope this image helps clarifies everything in terms of a header and vertical spacing. thanks!
Screenshot 2023-02-21 at 12 23 49 PM

…he size of the title for videos sections, added the additional spacing between the videos collections
@dev-smart-ui
Copy link
Contributor Author

Thanks for appreciating our work! Here the next addition:

  1. Removed the logo from the front of the page.
  2. I have used the correct logo to the pages.
  3. Added extra vertical spacing between the videos list collection.
  4. Increased the title size of the videos collection list.
    ....
    Let us know if everything is good.
    Thanks!

Copy link
Collaborator

@dennyglee dennyglee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks amazing - thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants