Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat:add Map Screen #13

Merged
merged 4 commits into from Nov 27, 2021
Merged

feat:add Map Screen #13

merged 4 commits into from Nov 27, 2021

Conversation

Muhesh7
Copy link
Contributor

@Muhesh7 Muhesh7 commented Nov 27, 2021

In this PR

  • Added Map Screen in main page
    • Implemented custom zoom-control widget for Map
    • Added MapRendering logics inside mapController
    • Modified Bottom Navigation Bar to adapt with MapScreen
  • Added flash button animation in scan screen
    • This is done to scan the QRcode of lock at night times.
    • implemented using obx widget.
    • Icon changes reactively passed on the flash status.
  • Modified build command in github/workflows/main.yml to supply map_key from github secrets to pass the workflow
    • flutter build apk --dart-define=map_key=${{secrets.MAP_KEY}}
    • The key is passed as dart-define argument, which is a best way to secure our MAP_KEY
    • To execute the application the following command is used:
      • flutter run --dart-define=map_key=<MAP_KEY>

@@ -1,11 +1,11 @@
import 'package:cycle_lock/bindings/auth_binding.dart';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file does not have widgets. Move the getPages function to a navigation folder?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah Will migrate those objects, navigation objects inside navigation folder and constant objects to constant folder

@Sudhindra3000 Sudhindra3000 merged commit a644ed5 into main Nov 27, 2021
@Sudhindra3000 Sudhindra3000 deleted the map branch April 1, 2022 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants