Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove asyncio #2

Merged
merged 4 commits into from
Oct 14, 2023
Merged

Remove asyncio #2

merged 4 commits into from
Oct 14, 2023

Conversation

link2xt
Copy link
Contributor

@link2xt link2xt commented Oct 6, 2023

Adapt for new deltachat_rpc_client which dropped asyncio.

Closes #1

@link2xt link2xt requested a review from adbenitez October 6, 2023 17:13
Adapt for new deltachat_rpc_client which dropped asyncio.
@link2xt
Copy link
Contributor Author

link2xt commented Oct 6, 2023

I have tested both examples, they work.

Prevent the bod from logging KeyboardInterrupt
as an exception in this case.
@adbenitez
Copy link
Contributor

thanks a lot! I will delay merging for some days until I can get back to this and prepare also all other bots

@link2xt
Copy link
Contributor Author

link2xt commented Oct 14, 2023

Could be merged already probably, because anyway if someone wants to use current version of this repo, they have to install old version (not even latest stable) of deltachat-rpc-client. This PR makes the repo compatible to the latest deltachat-rpc-client at least and I already use it in https://github.com/link2xt/localbot/ successfully.

Copy link
Contributor

@adbenitez adbenitez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks a lot!

@link2xt link2xt merged commit 2d6b890 into master Oct 14, 2023
@link2xt link2xt deleted the link2xt/no-async branch October 14, 2023 02:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Depend on stable version of deltachat-rpc-client
2 participants