Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add nodejs jsonrpc over stdio with @deltachat/stdio-rpc-server #69

Merged
merged 3 commits into from
May 20, 2024

Conversation

Simon-Laux
Copy link
Contributor

No description provided.

@Simon-Laux Simon-Laux requested a review from adbenitez May 10, 2024 04:41
Simon-Laux added a commit to deltachat/deltachat-core-rust that referenced this pull request May 11, 2024
- [x] figgure out how to build the packages (that it installs native
optional package automatically)
- [X] Make the gluecode
- [x] expose both the lowerlevel api that desktop uses (~~send objects
and receive objects~~, getting path of rpc-server is enough)
  - [X] and the higher level api needed for bots (jsonrpc client)
  - [X] typescript types
- [x] automatically pick the right binary from npm or allow getting it
from env var, or give out an error (throw error)
- [x] find out how to dev locally (use local built core in dc desktop) -
there is the question of how to link the typescript client and the task
to add a search in the cargo target folder for a debug build or a
different way, find out some good flow that we can use and document for
dc desktop + locally built core development
- [x] build the packages in ci
- [x] fix that deltachat-rpc-server is not executable

postponed:
- [ ] publish from ci
   - [ ] add key/token to deploy to npm 

Closes #4694

## Related prs
- deltachat-bot/echo#69
- deltachat/deltachat-desktop#3567

---------

Co-authored-by: link2xt <link2xt@testrun.org>
@Simon-Laux Simon-Laux marked this pull request as ready for review May 15, 2024 19:21
@Simon-Laux Simon-Laux requested a review from link2xt May 15, 2024 19:21
@Simon-Laux Simon-Laux requested a review from missytake May 15, 2024 19:49
@Simon-Laux Simon-Laux merged commit b411886 into master May 20, 2024
@Simon-Laux Simon-Laux deleted the simon/nodejs_jsonrpc_stdio branch May 20, 2024 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants