Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set stock translations before starting I/O #2288

Closed
link2xt opened this issue May 2, 2022 · 0 comments · Fixed by #2290
Closed

Set stock translations before starting I/O #2288

link2xt opened this issue May 2, 2022 · 0 comments · Fixed by #2290
Assignees
@adbenitez
Labels
bug
Projects
1.30: Reliability and Speed Releases

Comments

@link2xt
Copy link
Contributor

link2xt commented May 2, 2022

Stock translations are set here:

deltachat-android/src/org/thoughtcrime/securesms/ApplicationContext.java

Line 139 in 647ffd3

DcHelper.setStockTranslations(this);

IO is started here:

deltachat-android/src/org/thoughtcrime/securesms/ApplicationContext.java

Line 115 in 647ffd3

dcAccounts.startIo();

If there are pending MDNs, an MDN may be generated in English because the translation is not set yet:
https://support.delta.chat/t/language-of-return-receipts/2075/3
@r10s r10s added the bug label May 2, 2022
@adbenitez adbenitez self-assigned this May 4, 2022
@adbenitez adbenitez added this to To do in 1.30: Reliability and Speed Releases via automation May 4, 2022
@adbenitez adbenitez mentioned this issue May 4, 2022
Merged
@r10s r10s moved this from To do to In progress in 1.30: Reliability and Speed Releases May 4, 2022
1.30: Reliability and Speed Releases automation moved this from In progress to Done May 4, 2022
r10s added a commit to deltachat/deltachat-ios that referenced this issue May 5, 2022
@r10s
set translations before starting I/O
9127547 
If there are pending MDNs, an MDN may be generated in English
because the translation is not set yet.

counterpart of deltachat/deltachat-android#2288
@r10s r10s mentioned this issue May 5, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adbenitez adbenitez

Labels
bug
Projects
No open projects
1.30: Reliability and Speed Releases
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

set translations before starting I/O deltachat/deltachat-android
3 participants
@r10s @link2xt @adbenitez