Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implement sticker visualization #1823

Merged
merged 5 commits into from Mar 10, 2021
Merged

implement sticker visualization #1823

merged 5 commits into from Mar 10, 2021

Conversation

adbenitez
Copy link
Member

@adbenitez adbenitez commented Mar 3, 2021 •
edited

Sticker picker is not implemented, just receiving(from DC Desktop, bots or future DC versions) and forwarding stickers
(code adapted from Signal)

Screenshot:

deltachat-2021-03-03-045259

Feel free to tweak at taste :)

@link2xt
Copy link
Contributor

link2xt commented Mar 3, 2021

Looks good, what about lottie sticker support from DeltaLab? Do you plan to port it too?

@r10s
Copy link
Member

r10s commented Mar 3, 2021

wow! nice!

and makes some sense to do implement displaying first. so when we find the time to implement a picker at some point and sort remaining question wrt decentralization, shipped releases will already be able to show stickers :)

did not look at the code much yet, though.

@adbenitez
Copy link
Member Author

Looks good, what about lottie sticker support from DeltaLab? Do you plan to port it too?

at some point yes, but that has some disadvantages, IIRC, the minimum android SDK version we support will need to be increased

Hocuri
Hocuri reviewed Mar 7, 2021
View reviewed changes
Copy link
Collaborator

@Hocuri Hocuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for pushing this forward!

res/layout/conversation_item_received.xml Outdated Show resolved Hide resolved
res/layout/conversation_item_sent.xml Outdated Show resolved Hide resolved
src/org/thoughtcrime/securesms/ConversationItem.java Outdated Show resolved Hide resolved
src/org/thoughtcrime/securesms/components/ThumbnailView.java Outdated Show resolved Hide resolved
src/org/thoughtcrime/securesms/components/ThumbnailView.java Outdated Show resolved Hide resolved
src/org/thoughtcrime/securesms/components/ThumbnailView.java Outdated Show resolved Hide resolved
@Hocuri
Copy link
Collaborator

Hocuri commented Mar 10, 2021

BTW, do sticker messages that are at the same time a reply to another message look good? I coudn't test this.

Just crossed my mind, but we don't have to think about this now, stickers don't have to be perfect from the beginning. I think this pr can be merged.

@Hocuri Hocuri merged commit beee60d into master Mar 10, 2021
@Hocuri Hocuri deleted the adb-sticker-view branch March 10, 2021 09:55
@r10s r10s mentioned this pull request Mar 15, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hocuri Hocuri Hocuri approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@adbenitez @link2xt @r10s @Hocuri