allow to remove all messages from current chat #2175
Conversation
|
this does what is described in deltachat/deltachat-core-rust#1299 but in the Android side, could be tweaked when such core api is added |
res/menu/conversation_clear.xml
Outdated
| <?xml version="1.0" encoding="utf-8"?> | ||
| <menu xmlns:android="http://schemas.android.com/apk/res/android"> | ||
|
|
||
| <item android:title="@string/menu_delete_messages" |
There was a problem hiding this comment.
I reused this string but maybe a "clear chat"/"clear history" string could be added
|
To test the changes in this pull request, install this apk: |
|
is there a core function for it or is this using ui code to delete each message? |
|
ftr, desktop does a similar thing since deltachat/deltachat-desktop#2909 - if there are no issues with that, we can maybe revive this pr. |
@r10s so desktop already have this and some users already have complained in community channels about this issue that they can do it in desktop but can't in Android, is something blocking from merging this PR? |
|
desktop is using an unstranslated string "clear chat" it seems: cc @Simon-Laux |
|
yip, i think, we can get that in, at some point a core-function would be nice and more performant, but it seems good enough already this way. to the wording: whatsapp (ios/android) is using the term "Clear Chat" as well so, i'd say "Clear Chat", as already introduced on desktop seems okay, esp. as in the following confirmation we ask explicitly to confirm deletion of "N messages". so, what's missing is only the string "Clear Chat" :) |
adbenitez
force-pushed
the
adb-clear-chat
branch
from
7eb1724
to
ffb788e
Compare
ok, changed to use "Clear Chat" string |
|
To test the changes in this pull request, install this apk: |
to decide: when chat has no messages, what to do? hide the menu item? show an error toast on menu item selected? show a dialog?
currently the same dialog is show for all cases so when there is no messages the "delete 0 messages?" dialog is shown and does nothing