Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update org.maplibre.gl to version 9.5.2 #2351

Merged
merged 2 commits into from
Jul 22, 2022
Merged

update org.maplibre.gl to version 9.5.2 #2351

merged 2 commits into from
Jul 22, 2022

Conversation

adbenitez
Copy link
Member

hopefully closes #2349

@adbenitez
Copy link
Member Author

just updating the version number won't do, the api changed:

/home/dc/projects/deltalab-android/src/org/thoughtcrime/securesms/map/MapActivity.java:71: error: no suitable method found for getInstance(Context,String)
            Mapbox.getInstance(context, BuildConfig.MAP_ACCESS_TOKEN);      
                  ^                                                                                                                                                                                                              
    method Mapbox.getInstance(Context) is not applicable
      (actual and formal argument lists differ in length)  
    method Mapbox.getInstance(Context,String,WellKnownTileServer) is not applicable                                                                                                                                              
      (actual and formal argument lists differ in length)                                                                                                                                                                        
/home/dc/projects/deltalab-android/src/org/thoughtcrime/securesms/map/MapActivity.java:114: error: cannot find symbol
        mapFragment.getMapAsync(mapboxMap -> mapboxMap.setStyle(Style.MAPBOX_STREETS, style -> {                                                                                                                                 
                                                                     ^
  symbol:   variable MAPBOX_STREETS                                                                             
  location: class Style

I am not really deep in this part of the code and would take more time to read and understand and fix in emacs without much help from the editor wrt autocompletion etc. so maybe @Hocuri if you know how to fix this quickly feel free to take over the PR

@adbenitez
Copy link
Member Author

ok I am fixing it already, it is not that hard following the notes on maplibre/maplibre-native#90

@adbenitez adbenitez changed the title [wip] update org.maplibre.gl to version 9.5.2 update org.maplibre.gl to version 9.5.2 Jul 22, 2022
@adbenitez adbenitez requested review from r10s and Hocuri July 22, 2022 21:21
Copy link
Member

@r10s r10s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, i also build+tested on one device.

thanks a looooooooooooooooott! <3

@adbenitez
Copy link
Member Author

yeah, analyzing the apk now and following the steps from #2349 (comment) now the mapbox-android-account stuff is gone 🎉

@adbenitez
Copy link
Member Author

adbenitez commented Jul 22, 2022

@r10s feel free to merge, I am back AFK "offline"/dc-only mode :D

(12% battery, blackout, etc)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exodus tracker finds GMS classes
2 participants