Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

display reactions #2554

Merged
merged 5 commits into from Sep 27, 2023
Merged

display reactions #2554

merged 5 commits into from Sep 27, 2023

Conversation

adbenitez
Copy link
Member

@adbenitez adbenitez commented May 5, 2023

  • implement JSON-RPC API for reactions in the Java side
  • display reactions in the message bubbles
  • when user click the reactions show detailed info about who reacted and counts of reactions. postponed to a subsequent PR

related core PRs:

close #2401

@adbenitez adbenitez requested review from r10s and link2xt May 5, 2023 20:06
@r10s r10s mentioned this pull request May 6, 2023
@adbenitez adbenitez changed the title implement get_msg_reactions() JSON-RPC API [WIP] display reactions May 9, 2023
@github-actions
Copy link

github-actions bot commented May 9, 2023

To test the changes in this pull request, install this apk:
📦 app-preview.apk

@github-actions
Copy link

To test the changes in this pull request, install this apk:
📦 app-preview.apk

@github-actions
Copy link

To test the changes in this pull request, install this apk:
📦 app-preview.apk

@adbenitez adbenitez changed the base branch from master to stable September 27, 2023 18:13
@adbenitez adbenitez changed the base branch from stable to master September 27, 2023 18:13
@adbenitez adbenitez changed the base branch from master to stable September 27, 2023 18:17
@github-actions
Copy link

To test the changes in this pull request, install this apk:
📦 app-preview.apk

@r10s
Copy link
Member

r10s commented Sep 27, 2023

the story continues 🎉 🤘 🚀

@github-actions
Copy link

To test the changes in this pull request, install this apk:
📦 app-preview.apk

@adbenitez adbenitez changed the title [WIP] display reactions display reactions Sep 27, 2023
@github-actions
Copy link

To test the changes in this pull request, install this apk:
📦 app-preview.apk

@@ -0,0 +1,37 @@
<?xml version="1.0" encoding="utf-8"?>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

red pill or blue pill?

@adbenitez adbenitez merged commit 9fd21b4 into stable Sep 27, 2023
2 checks passed
@adbenitez adbenitez deleted the adb/add-reactions-api branch September 27, 2023 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

show reactions
2 participants