streamline map wording #2562
streamline map wording #2562
Conversation
- remove prefix 'Show', we are not using it at most other places, nor do comparable UI - move 'All Locations' below 'All Media', this seems to be more logical (we were even thinking of making 'Locations' a tap in 'Media')
…s, maybe also the better title for the in-chat-maps in general)
r10s
force-pushed
the
streamline-map-wording2
branch
from
7592057
to
3169a19
Compare
| @@ -157,6 +157,7 @@ | |||
| <string name="switch_camera">Switch Camera</string> | |||
| <string name="toggle_fullscreen">Toggle Full Screen Mode</string> | |||
| <string name="location">Location</string> | |||
| <string name="locations">Locations</string> | |||
There was a problem hiding this comment.
I don't understand, why add this string that seems to be used nowhere?
Is this still by accident and should be removed again in a follow-up PR?
There was a problem hiding this comment.
it is used in some ios experiments, where the word "Map" is not really fitting when showing a number or "None" beside (not yet there, but planned):
also, as we're talking about "sending/deleting/all/whatnot locations" also elsewhere, this seems to be a natural fit.
nb: the map is a 50k webxdc with leaflet, if that works out nicely at the end, we can think over using that on android/desktop as well, finally getting rid of mapbox - plus having an option to the user replacing the whole map engine.
however, as said, this is only an experiment currently, with close to no priority these days :)
this pr syncs the wording of "All Location" to what is used elsewhere in the app and common in apps in general (omitting the verb "show" before objects).
see commit messages for more details.
before / after: