Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

register to handle i.delta.chat links #2922

Merged
merged 1 commit into from
Jan 20, 2024
Merged

register to handle i.delta.chat links #2922

merged 1 commit into from
Jan 20, 2024

Conversation

adbenitez
Copy link
Member

close #2920

@adbenitez
Copy link
Member Author

in one Xiaomi phone it doesn't open in DC but in the browser, in another phone (CalyxOS) it also doesn't open in DC by default but going to system settings of DC I can see a "open supported links" option and there you have to manually enable to open i.delta.chat directly in DC,

it says something about "zero verified links" and an info at the bottom points "An app can verify links to automatically open in the app" so it seems that to open links automatically the i.delta.chat needs to be tweaked in some way to report that DC app is allowed to handle their links instead of opening in browser, makes some sense, ex. then no fake app can open WhatsApp, or Signal links etc. but it makes all more complicated and less useful

@adbenitez

This comment was marked as resolved.

@adbenitez
Copy link
Member Author

Copy link

To test the changes in this pull request, install this apk:
📦 app-preview.apk

@hpk42
Copy link
Contributor

hpk42 commented Jan 17, 2024 via email

@adbenitez
Copy link
Member Author

could you provide the contents of the "assetlinks.json" file? we can put it to i.delta.chat and then it should work, i guess? https://developer.android.com/training/app-links/verify-android-applinks#web-assoc

yes, but sadly that will not work for fdroid builds, because we don't own the signing key IIRC, but it will work for gplay releases, I guess it is not the end of the world, anyway worse case the page gets opened in the browser and then user can click link/button that then opens in DC, and I expect the fdroid users be much less than gplay

@adbenitez adbenitez marked this pull request as ready for review January 18, 2024 23:03
@adbenitez adbenitez requested a review from r10s January 18, 2024 23:03
Copy link
Member

@r10s r10s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm, did not test.

for testing, it seems esp. important that existing OPENPGP4FPR links continue working (which one can easily test by open the i.delta.chat in the browser manually, then the page shows the OPENPGP4FPR links)

@adbenitez adbenitez merged commit a1cc00a into main Jan 20, 2024
2 checks passed
@adbenitez adbenitez deleted the adb/issue-2920 branch January 20, 2024 04:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

allow to open i.delta.chat links in-app
3 participants