-
-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
organize project structure #3127
Conversation
adbenitez
commented
Jun 12, 2024
- move res and assets folders to src/main/
- update scripts and transifex config to use the new paths
file_filter = src/main/res/values-<lang>/strings.xml | ||
source_file = src/main/res/values/strings.xml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure if this will make the tx program to output to src/main/res instead of ./res, this needs to be tested
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should be fine, we will find out easily sooner or later :)
these are the defaults for android projects, right? |
To test the changes in this pull request, install this apk: |
but is it really default to put apart from begin default, what is the advantage of the now longer paths? that we can more easily adapt for flavours in the already know way? are there other advantages? just because of interest, iirc, it took me some effort years ago to go for an alternative app-icon that includes the word "DEV" ... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some questions, but overall probably just fine!
thanks for the chore!
ftr, that seems to use the same approach as now everywhere, see documentation in |
yes, in fact that is what the debug folder is already doing to override the app icon, it might sound confusing at first because you might thing of src as code, but it is more like all your app sources and content, and it is more clear when you see the flavor folders inside, then each flavor can have its own res, assets, AndroidManifest and java code you can see a common project structure creating a new project in Android Studio, the common thing is to wrap the src folder inside an app folder but that seemed to add more complexity, since you then need to have a top level build.gradle plus another one inside app folder etc you can see an example project tree at https://developer.android.com/build |
not much, other than being in the standard place were other android developers would expect, and in the same level as alternative res/assets for other flavors |