-
-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
offer mailto link parsing api #4620
Comments
How the API should look like? What function should be provided, which arguments it takes and what it returns? I remove "good first issue" for now, I think it is more suitable for issues that only require an implementation without any discussion. |
something like:
an error is thrown if the mailto uri failed to be parsed, empty To is valid, the chatlist is offered for choosing in that case |
this has low priority tho, all the UIs have some custom mailto parsing currently, just nice to unify and to avoid problems, ex. the parser on android is too strict IIRC causing invalid parsing for some mailto urls that work in apps like k9mail |
So it is going to replace this Android file? |
close #4620 This PR introduces a new core API to parse mailto links into a uniform data format. This could be used to unify the different implementations on the current platforms. To complete this PR we have to decide for which APIs we want to expose this (now) internal API (c, python, json-rpc, etc.), and if we want such an API at all as it doesn't have a corresponding UI-PR and is not _really_ needed.
mailto link parsing is implemented repeatedly in each UI client, in android mailto link parsing is far from perfect and it is known to be source of issues in the past and not parsing properly all mailto links etc.
it would be nice if core provided an API to simplify this, and avoid repeated implementation accross UIs
The text was updated successfully, but these errors were encountered: