Fix #1474 "Sending message to contact with < or > in Recipient gets treated as "Sent" but is not received"

[Hocuri]

Fix #1474 "Sending message to contact with < or > in Recipient gets treated as "Sent" but is not received".

As I was at it, I also extracted the correct name and address from addresses like Mueller, Dave <dave@domain.com>.

[r10s]

looks good to me logic-wise, but i would prefer if someone with a better idea of rust than me can also have a look at that

[link2xt]

You can use slice pattern to avoid indexing captures and ensuring that there are exactly 2 groups captured.

[Hocuri]

The shortest way I found to do this was:

    if let Some(captures) = ADDR_WITH_NAME_REGEX.captures(addr.as_ref()) {
        if let [n, a] = &captures.iter().collect::<Vec<_>>()[..] {
...

because

• it is not that easy to build a slice from a Captures struct
• a slice is not owned, so I can't use map but need the two ifs

[Hocuri]

So, I do not think this is worth it because it introduces quite some complexity (unless there is a way to express this shorter I did not find)

[r10s]

as this not fixes a critical bug, compared to the other fixes, but touches pretty critical things on incoming mails, i think we should merge this to master after we released android 1.8.1 resp. core1.33

[Hocuri]

The CI is failing with a timeout. From the logs:

87.25 [inbox-ac1] DC_EVENT_WARNING data1=0 data2=ThreadId(125) src/contact.rs:349: Bad address "mailer-daemon@hq5.merlinux.eu (mail delivery system)" for contact "<unset>".
87.25 [inbox-ac1] DC_EVENT_INFO data1=0 data2=ThreadId(125) src/imap/mod.rs:642: Read error for message 20200516164742.112564051B@hq5.merlinux.eu from "INBOX", trying over later: IMAP other error: dc_receive_imf error: Bad address supplied: "mailer-daemon@hq5.merlinux.eu (mail delivery system)".
87.25 [inbox-ac1] DC_EVENT_WARNING data1=0 data2=ThreadId(125) src/imap/mod.rs:663: 2 mails read from "INBOX" with 2 errors.

Seems that DC receives a mail with
From: mailer-daemon@hq5.merlinux.eu (mail delivery system) (WTF????)
which is now rejected because it contains spaces.

Should we change merlinux's mail server configuration? Or fix this so that the mailer deamon does not have to send us messages (they probably say that the message could not be sent)?

Or be more relaxed when receiving messages (I do not think that we should accept mails where FROM is bad but we could add them to the database to avoid downloading them again; leaving from_id in dc_receive_imf 0 should be sufficient)?

[link2xt]

Seems that DC receives a mail with
From: mailer-daemon@hq5.merlinux.eu (mail delivery system) (WTF????)
which is now rejected because it contains spaces.

It is rejected because mailparse crate can't parse comments. According to https://tools.ietf.org/html/rfc5322#page-18 there is an optional [CFWS] after domain-literal, which stands for Comment or Folding White Space. (mail delivery system) is a comment and mailparse can't parse it.

[Hocuri]

So, what do we do? Use the unstable version from master? Wait for the mailparse update? Or be more strict later and only merge the sanitize_name_and_addr() thing now?

[hpk42]

address-comment parsing is at least not breaking anymore: staktrace/mailparse@3e29988 i think we could pull in that commit (or master) from mailparse in our Cargo.toml. i also opened staktrace/mailparse#66 to ask for a new release.

…

On Sun, May 17, 2020 at 04:39 -0700, Hocuri wrote: So, what do we do? Use the unstable version from master? Wait for the mailparse update? Or be more strict later and only merge the sanitize_name_and_addr() thing now? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: #1476 (comment)

[Hocuri]

Yay, it works! Shall I merge this PR?