python: remove arbitrary timeouts from tests #3059
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
link2xt
force-pushed
the
remove-arbitrary-timeouts
branch
3 times, most recently
from
51f5e9c
to
f2ecdf1
Compare
|
Made all the tests succeed on a network with 5 second ping. |
Hocuri
approved these changes
Feb 5, 2022
| res = self.conn.idle_check(timeout=30) | ||
| if len(res) == 0: | ||
| raise TimeoutError | ||
| res = self.conn.idle_check() |
There was a problem hiding this comment.
Shouldn't this still raise a TimeoutError if len(res) == 0? Or will conn.idle_check() raise an error by itself in this case now?
There was a problem hiding this comment.
Without timeout it should not return without a response. If it still does, we return empty res and outside code will restart idle_check if it wants a response.
link2xt
force-pushed
the
remove-arbitrary-timeouts
branch
from
f2ecdf1
to
c4b0f77
Compare
pytest-timeout already handles all deadlocks and is configurable with --timeout option. With this change it is possible to disable timeout with --timeout 0 to run tests on extremely slow connections.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pytest-timeout already handles all deadlocks and is configurable with
--timeout option. With this change it is possible to disable timeout
with --timeout 0 to run tests on extremely slow connections.
#skip-changelog