Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: recreate smtp table with AUTOINCREMENT #4390

Merged
merged 1 commit into from
May 12, 2023

Conversation

link2xt
Copy link
Collaborator

@link2xt link2xt commented May 10, 2023

This ensures the rows cannot be confused accidentally when referred by row_id.

@r10s
Copy link
Member

r10s commented May 10, 2023

the missing rfc724_mid will cause problems on export -> import to a previous version - which is quite common, eg. there is always quite some time before all systems synchronize wrt new versions. if we do eg. an export from upcoming android 1.36.6 and import that to 1.36.5 , 1.36.5 will stop working as the INSERT INTO smtp will fail.

even if that is not nice, and the opportunity seems favorable, i suggest to keep the column. or use a new table so we can drop the old one at some later point.

apart from that, lgtm

@link2xt link2xt force-pushed the link2xt/smtp-autoincrement branch from 37c2401 to 3ebfe8e Compare May 10, 2023 13:26
@link2xt
Copy link
Collaborator Author

link2xt commented May 10, 2023

I restored rfc724_mid column, but without the index because it is not used anyway.

@link2xt link2xt force-pushed the link2xt/smtp-autoincrement branch from 3ebfe8e to da618bf Compare May 10, 2023 13:28
Copy link
Member

@r10s r10s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if rfc724_mid is not used otherwise (neither in older nor in newer versions), i think, the rfc724_mid can still be removed from INSERT INTO smtp (as in commits before) - as long as the column itself exist to be compatible with existing releases.
EDIT: after direct talk: filling rfc724_mid makes sense in case we use the column in the future.

otherwise, lgtm now

This ensures the rows cannot be confused accidentally
when referred by row_id.
@link2xt link2xt force-pushed the link2xt/smtp-autoincrement branch from da618bf to d3afa67 Compare May 11, 2023 17:07
@link2xt link2xt merged commit c5b6bad into master May 12, 2023
37 checks passed
@link2xt link2xt deleted the link2xt/smtp-autoincrement branch May 12, 2023 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants