New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: disable fetch_existing_msgs
setting by default
#4423
Conversation
Another option would be to revert the |
This caused too many problems after switching the default setting for `show_emails` from DC_SHOW_EMAILS_OFF to DC_SHOW_EMAILS_ALL in <#4019> There is a topic <https://support.delta.chat/t/setting-no-chats-only-for-show-classic-e-mails-showing-classic-emails/2481> on the forum with multiple requests to revert this setting due to old emails being downloaded.
7a521d7
to
227396c
Compare
There was a related fix to the bug that may have caused download of >100 messages which may have been the reason for negative reports on this feature: #4383 |
This feature is by the way buggy because it first processes the whole Inbox, then the whole Sent folder. This way Delta Chat is unable to assign messages to the chats properly, as every time Reply-To field of the incoming message refers to the outgoing message, outgoing message is not processed yet and will only be processed after finishing the Inbox. If we want to reintroduce |
Note that from a user perspective, it's not only disabled by default, but completely, since there's no way to turn it on. So, if it turns out that this isn't missed by too many users, we should just remove the code completely. |
It was already effectively disabled before #4019 (enabling download of non-chat mails by default) because new users had no chat messages in the inbox and Delta Chat fetched only old chat messages. So in most cases users got no messages in the new setup and maybe only some old chat messages that happened to be unencrypted which is arguably worse than nothing. Now that this feature started doing something, users have problems when setting up a new account and get a huge number of contact requests. The only users who could have noticed this working were DeltaLab users which already had non-chat mails enabled by default, but it was mostly used with nauta.cu which has If we reintroduce |
This caused too many problems after switching the default setting for
show_emails
from DC_SHOW_EMAILS_OFF to DC_SHOW_EMAILS_ALL in #4019There is a topic https://support.delta.chat/t/setting-no-chats-only-for-show-classic-e-mails-showing-classic-emails/2481 on the forum with multiple requests to revert this setting due to old emails being downloaded.
Note that this does not disable fetching existing contacts.