Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: receive_imf: Don't break 1:1 chat protection if received an unverified message (#4597) #4632

Closed
wants to merge 3 commits into from
Closed

fix: receive_imf: Don't break 1:1 chat protection if received an unverified message (#4597) #4632

wants to merge 3 commits into from

Commits on Oct 26, 2023

  1. fix: receive_imf: Don't break 1:1 chat protection if received the ver… 

    …ified Autocrypt key (#4597)

For example, broadcast list messages are sent unencrypted, but their Autocrypt header still contains
the verified key. Thus we're sure that we still can encrypt to the peer and there's no need to break
the existing protection.
    @iequidoo
    iequidoo committed Oct 26, 2023
    Configuration menu
    Copy the full SHA
    83fa355 View commit details
    Browse the repository at this point in the history

  2. feat: Move unverified messages carrying current Autocrypt key from pr… 

    …otected 1:1 chats to ad-hoc groups

TODO: This should be squashed with the previous commit if we decide to go this way.
    @iequidoo
    iequidoo committed Oct 26, 2023
    Configuration menu
    Copy the full SHA
    0ea1e93 View commit details
    Browse the repository at this point in the history

  3. feat: Move unverified messages which don't introduce a new Autocrypt … 

    …key from protected 1:1 chats to ad-hoc groups

This prevents protected 1:1 chats from breaking by messages sent by classical MUAs.

TODO: Some `tests::verified_chats` tests are failing, but as far as i see from the log, the tests
must be fixed, the change itself looks ok. Not fixing the tests now, not sure we will merge this as
it's just POC.
    @iequidoo
    iequidoo committed Oct 26, 2023
    Configuration menu
    Copy the full SHA
    6777173 View commit details
    Browse the repository at this point in the history