Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Clear VerifiedOneOnOneChats config on backup #4681

Merged
merged 1 commit into from
Sep 5, 2023

Conversation

Hocuri
Copy link
Collaborator

@Hocuri Hocuri commented Sep 4, 2023

If the user makes a backup from a UI that supports the experimental verified 1:1 chats (e.g. nightly Android) and imports it into a UI that doesn't, then this config should be cleared.

We already talked about this a long time ago after @Simon-Laux noticed this problem, but I think we didn't actually solve it back then?

Best to review with whitespace changes disabled.

If the user makes a backup from a UI that supports the experimental
verified 1:1 chats (e.g. nightly Android) and imports it into a UI that
doesn't, then this config should be cleared.

We already talked about this a long time ago, but I think we didn't
actually solve it back then?

Review with whitespace changes disabled.
@Hocuri Hocuri force-pushed the hoc/clear-verifiedchats-on-backup branch from 5d8d1b0 to d9e0199 Compare September 4, 2023 16:04
Copy link
Contributor

@hpk42 hpk42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Hocuri Hocuri changed the title fix: Clear VerifiedOneOnOneChats setting on backup fix: Clear VerifiedOneOnOneChats config on backup Sep 4, 2023
Copy link
Collaborator

@link2xt link2xt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, should also work with backup transfer as it uses export_database internally.

@Hocuri Hocuri merged commit 2587ebb into master Sep 5, 2023
36 checks passed
@Hocuri Hocuri deleted the hoc/clear-verifiedchats-on-backup branch September 5, 2023 07:15
@link2xt link2xt mentioned this pull request Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants