Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove receiver limit on .xdc size #5058

Merged
merged 1 commit into from Dec 1, 2023

Conversation

link2xt
Copy link
Collaborator

@link2xt link2xt commented Nov 28, 2023

If we have downloaded the file anyway,
might as well allow to open it.

There is a corresponding discussion on the forum: https://support.delta.chat/t/proposal-remove-bump-xdc-file-size-cap/2828

If we have downloaded the file anyway,
might as well allow to open it.
@r10s
Copy link
Member

r10s commented Nov 28, 2023

i do not remember exactly: i think, the idea was that one cannot send too large webxdc by a modified client, to force ppl more into respecting the size limits

maybe okay to lift it, i am +/-0 here, one can still not sent them out easily

@Septias
Copy link
Contributor

Septias commented Dec 1, 2023

I think most developers are cautious enough to produce small webxdcs and having a limit does more harm than good. As @WofWca said in the forum, ported apps are very hard to get smaller without a huge amount of work as well as wasm-apps which include big binaries. It's fine for me to remove the limit.

@link2xt
Copy link
Collaborator Author

link2xt commented Dec 1, 2023

We can still enforce the limit on the apps added to xstore@testrun.org and maintain some quality standards there.

@link2xt
Copy link
Collaborator Author

link2xt commented Dec 1, 2023

one can still not sent them out easily

On forwarding the limit is currently not enforced by the way, I can forward large xdcs that I received already.

@r10s
Copy link
Member

r10s commented Dec 1, 2023

having a limit does more harm than good

good point. i agree that no strict limit is probably the better tradeoff, even more when thinking about webxdc in the broader term, not only about missing deduplication in dc (which is probably still not a huge issue, most images and all videos are larger than a webxdc and also forwarded)

@link2xt link2xt merged commit 9cc9579 into main Dec 1, 2023
38 checks passed
@link2xt link2xt deleted the link2xt/remove-webxdc-receiving-limit branch December 1, 2023 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants