Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Add tolerance to MemberListTimestamp (#5366) #5376

Merged
merged 2 commits into from
Apr 8, 2024
Merged

fix: Add tolerance to MemberListTimestamp (#5366) #5376

merged 2 commits into from
Apr 8, 2024

Commits on Mar 26, 2024

  1. fix: Add tolerance to MemberListTimestamp (#5366) 

    Let's add a 1-minute tolerance to `Params::MemberListTimestamp`.

This adds to the group membership consistency algo the following properties:
- If remote group membership changes were made by two members in parallel, both of them are applied,
  no matter in which order the messages are received.
- If we remove a member locally, only explicit remote member additions/removals made in parallel are
  allowed, but not the synchronisation of the member list from "To". Before, if somebody managed to
  reply earlier than receiving our removal of a member, we added it back which doesn't look good.
    @iequidoo
    iequidoo committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    4781bd0 View commit details
    Browse the repository at this point in the history

  2. test: display_chat(): Don't add day markers 

    Otherwise golden_test_chat() fails when run around midnight.
    @iequidoo
    iequidoo committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    a2b28f1 View commit details
    Browse the repository at this point in the history