Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rpc npm: rename shutdown method to close and add muteStdErr option to mute the stderr output #5588

Merged
merged 1 commit into from
May 17, 2024

Conversation

Simon-Laux
Copy link
Member

No description provided.

@link2xt
Copy link
Collaborator

link2xt commented May 17, 2024

deltachat-rpc-server does not print anything to stderr anyway normally, is anyone going to use this option? I think it's better if it just always prints to stderr of the parent process if there is something to print and have no settings.

@Simon-Laux
Copy link
Member Author

It is annoying in my migration test, there I need the option to turn it off

@Simon-Laux Simon-Laux merged commit d8e9827 into main May 17, 2024
38 checks passed
@Simon-Laux Simon-Laux deleted the simon/npm-rpc-fix-closing-andmute-stderr-option branch May 17, 2024 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants