Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use "ir.testrun.org" as default iroh relay #5609

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

Septias
Copy link
Contributor

@Septias Septias commented May 20, 2024

close #5591

@Septias Septias changed the title Sk/relay fix: don't use relay if chatmail doesn't provide one May 20, 2024
RelayMode::Default
}
#[cfg(not(test))]
RelayMode::Disabled
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you should at least print a big warning in this case, given that iroh won't work in this setup with deltachat currently

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commented about this in the issue aswell

@link2xt link2xt force-pushed the debug-iroh-2 branch 5 times, most recently from 9e14e69 to 37c771d Compare May 25, 2024 05:52
@link2xt link2xt mentioned this pull request May 26, 2024
@Septias Septias changed the base branch from debug-iroh-2 to main May 27, 2024 12:37
@Septias Septias requested a review from link2xt May 27, 2024 12:45
@Septias Septias changed the title fix: don't use relay if chatmail doesn't provide one fix: Use "ir.testrun.org" as default iroh relay May 27, 2024
Septias added a commit to deltachat/deltachat-desktop that referenced this pull request May 27, 2024
@Septias
Copy link
Contributor Author

Septias commented Jun 4, 2024

The JSON-RPC python tests are failing because we can't set [cfg(test)] there. Maybe we can compile json-rpc-server with RUSTFLAGS='--cfg test=1', or we can just add an internal config option to use iroh relays. The third option is to check for some env var like IROH_RELAY=b1.testrung.org to choose the iroh relay. I don't really have an opinion on what is best @link2xt

}
#[cfg(not(test))]
RelayMode::Custom(RelayMap::from_url(
Url::parse("ir.testrun.org").unwrap().into(),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Parsing plain URL without https:// results in "called Result::unwrap() on an Err value: RelativeUrlWithoutBase"

@Septias Septias requested a review from link2xt June 4, 2024 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Do not use default iroh relays
3 participants