fix: Fetch existing messages for bots as InFresh (#4976)
#5692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iequidoo
force-pushed
the
iequidoo/fetch_existing_msgs-bot
branch
from
4bbe790
to
502cde5
Compare
link2xt
approved these changes
Jun 16, 2024
|
Would be nice to document this behavior in |
iequidoo
force-pushed
the
iequidoo/fetch_existing_msgs-bot
branch
from
502cde5
to
b89a6fc
Compare
iequidoo
commented
Jun 17, 2024
| @@ -696,6 +696,9 @@ async fn add_parts( | |||
| prevent_rename: bool, | |||
| verified_encryption: VerifiedEncryption, | |||
| ) -> Result<ReceivedMsg> { | |||
| let is_bot = context.get_config_bool(Config::Bot).await?; | |||
| // Bots handle existing messages the same way as new ones. | |||
| let fetching_existing_messages = fetching_existing_messages && !is_bot; | |||
There was a problem hiding this comment.
I think it's more straigtforward to reset fetch_existing_messages here for bots as it is checked in several places
Before, if `Config::FetchExistingMsgs` is set, existing messages were received with the `InSeen` state set, but for bots they must be `InFresh` and also `IncomingMsg` events should be emitted for them so that they are processed by bots as it happens with new messages.
…ts (#4976) Test bots are run with `fetch_existing_msgs` set, so messages must be deleted immediately not to be processed again after a bot redeployment.
iequidoo
force-pushed
the
iequidoo/fetch_existing_msgs-bot
branch
from
b89a6fc
to
010f2a2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commit messages.
This should finally fix #4976
After the second commit only webxdc realtime tests are failing.