test(deltachat-rpc-client): test that webxdc realtime data is not reordered on the sender #5696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rdered on the sender
This was referenced Jun 17, 2024
|
Since there is no reordering on the core side, problem is either in the UI (both Android and Desktop) or Node.js bot here: https://github.com/link2xt/xdcterm/blob/0997b62094f9df8ab7ddc55e782fc5a5bb66a40a/index.js#L15-L23 |
|
The problem was fixed on the bot side: link2xt/xdcterm@b58d147 The test is useful anyway to prevent any sort of regressions in the core. |
iequidoo
reviewed
Jun 18, 2024
| for i in range(200): | ||
| while 1: | ||
| event = ac2.wait_for_event() | ||
| if event.kind == EventType.WEBXDC_REALTIME_DATA and bytes(event.data) != b"hello": |
There was a problem hiding this comment.
Shouldn't the event with "hello" be consumed by wait_receive_realtime_data([(ac2_webxdc_msg, b"hello")]) above? And can it be emitted several times?
There was a problem hiding this comment.
It is emitted 10 times by setup_thread_send_realtime_data.
iequidoo
approved these changes
Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5688