Switch mailparsing to mailparse #904

dignifiedquire · 2019-11-28T17:05:00Z

This uses mailparse for parsing and `lettre_email for mime generation.

need to pull Add encrypted multipart for MIME (RFC 1847) niax/rust-email#51 into lettre_email
use mime, instead of manually parsing content types in mimeparser.rs
cleanup mimeparser.rs
update securejoin
make all tests pass

link2xt · 2019-11-29T14:12:50Z

@dignifiedquire Remove .rsynclist

This file alone adds 3k lines

r10s · 2019-11-30T01:09:31Z

just played around a bit, i could sent out unencrypted mails!

whats came over my way is that the To: field repeats which may lead into group-chats instead of one-to-one-chats. although this could probably fixed on group-creation, i think it is better not to add ourself to the To: list - even not if bcc_self is enabled and ourself is added as a recipient for the smtp-server.

hpk42 · 2019-12-02T14:35:47Z

src/error.rs

+    #[fail(display = "Building invalid Email: {:?}", _0)]
+    LettreError(#[cause] lettre_email::error::Error),
+    #[fail(display = "FromStr error: {:?}", _0)]
+    FromStr(#[cause] mime::FromStrError),


according to latest discussions and PRs from @link2xt @flub and me we put errors into each module (see sql/smtp and imap.rs). but that doesn't need to be part of this PR now.

hpk42 · 2019-12-02T14:36:11Z

src/imap.rs

-                unsafe {
-                    dc_receive_imf(context, &body, folder.as_ref(), server_uid, flags as u32);
-                }
+                dc_receive_imf(context, &body, folder.as_ref(), server_uid, flags as u32);


w.o.n.d.e.r.full :)

incredible. awesome. just great.

src/mimefactory.rs

hpk42 · 2019-12-02T14:56:42Z

src/mimefactory.rs

+                        .body(encrypted)
+                        .build(),
+                )
+                .header(("Subject".to_string(), "...".to_string()));


beautiful 💯

hpk42 · 2019-12-02T16:27:00Z

src/mimeparser.rs

+
+                if let Some(raw) = raw {
+                    mail_raw = raw;
+                    info!(context, "decrypted: {:?}", std::str::from_utf8(&mail_raw));


can this not crash if the mail_raw is invalid utf8?

it can, and it should not be there, I need to go and cleanup all my debugging logs

are there many debugging logs? I think what's more important is going through all from_utf8 if any.

hpk42 · 2019-12-02T16:30:55Z

src/mimeparser.rs

+        // Handle gossip headers
+        let gossip_headers = mail.headers.get_all_values("Autocrypt-Gossip")?;
+        parser.gossipped_addr =
+            update_gossip_peerstates(context, message_time, &mail, gossip_headers)?;


this seems wrong. We can only use and process gossip headers if they are in the encrypted part.

hpk42

Overall this looks great to me. Remaining from my side:

check all utf8 handling (maybe also in mailparse).
move the gossip header updates into the decryption part

dignifiedquire · 2019-12-03T13:20:09Z

dignifiedquire force-pushed the mailparse branch from dc9d85e to 0bc755c Compare November 29, 2019 13:07

dignifiedquire force-pushed the mailparse branch from f01ed5d to 19afe31 Compare November 30, 2019 01:05

dignifiedquire changed the title ~~[WIP] [experiment] switch mailparsing to mailparse~~ [WIP] switch mailparsing to mailparse Nov 30, 2019

dignifiedquire force-pushed the mailparse branch from 9f3bcb0 to 62a2f70 Compare December 1, 2019 20:46

dignifiedquire marked this pull request as ready for review December 2, 2019 07:53

dignifiedquire changed the title ~~[WIP] switch mailparsing to mailparse~~ Switch mailparsing to mailparse Dec 2, 2019

hpk42 reviewed Dec 2, 2019

View reviewed changes

src/mimefactory.rs Show resolved Hide resolved

hpk42 reviewed Dec 2, 2019

View reviewed changes

src/mimefactory.rs

.body(encrypted)

.build(),

)

.header(("Subject".to_string(), "...".to_string()));

Copy link

Contributor

hpk42 Dec 2, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

beautiful 💯

hpk42 reviewed Dec 2, 2019

View reviewed changes

dignifiedquire added 15 commits December 3, 2019 12:22

first compile

d2de2ae

some things

1f8d253

remove mmime

dbd6303

Implement message generation using lettre_email

47197aa

integrate encryption when sending

c69a240

remove dead code

9196ed1

restructure mimefactory

5079e15

implement mdn rendering

5adde12

cleanup and finish missing parts

734bbff

less dead code, and update test

48dd3b8

switch to forked rust-email

7d3a56a

fix mailparsing test

64fcd56

some fixes for mdn handling

6bb2ada

fix various parsing and sending issues

d528725

fix content-type setting and some encryption

e985887

dignifiedquire and others added 4 commits December 3, 2019 12:25

fix chat-verified

1e7afa9

cleanup mimeparser and use mime

4307446

refactor: unsafe, CStr and libc moved out

db88212

remove debug logging and fix update_gossip_headers location

1c5a3e6

dignifiedquire force-pushed the mailparse branch from ead3e05 to 1c5a3e6 Compare December 3, 2019 11:25

fixup: remove double mimefactory

affdf72

hpk42 approved these changes Dec 3, 2019

View reviewed changes

r10s merged commit fe2a4b7 into master Dec 3, 2019

r10s deleted the mailparse branch December 3, 2019 13:16

r10s mentioned this pull request Dec 22, 2019

Replace mmime with rust-email #473

Closed

hpk42 restored the mailparse branch January 29, 2020 15:27

link2xt deleted the mailparse branch June 16, 2021 21:21

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Switch mailparsing to mailparse #904

Switch mailparsing to mailparse #904

dignifiedquire commented Nov 28, 2019 •

edited

Loading

link2xt commented Nov 29, 2019 •

edited

Loading

r10s commented Nov 30, 2019 •

edited

Loading

hpk42 Dec 2, 2019

hpk42 Dec 2, 2019

r10s Dec 2, 2019

hpk42 Dec 2, 2019

hpk42 Dec 2, 2019

dignifiedquire Dec 2, 2019

hpk42 Dec 2, 2019

hpk42 Dec 2, 2019

hpk42 left a comment •

edited

Loading

dignifiedquire commented Dec 3, 2019

Switch mailparsing to mailparse #904

Switch mailparsing to mailparse #904

Conversation

dignifiedquire commented Nov 28, 2019 • edited Loading

link2xt commented Nov 29, 2019 • edited Loading

r10s commented Nov 30, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

hpk42 left a comment • edited Loading

Choose a reason for hiding this comment

dignifiedquire commented Dec 3, 2019

dignifiedquire commented Nov 28, 2019 •

edited

Loading

link2xt commented Nov 29, 2019 •

edited

Loading

r10s commented Nov 30, 2019 •

edited

Loading

hpk42 left a comment •

edited

Loading