Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[0] Implement Stickers, rework emoji picker, refactor folder structure #1032

Merged
merged 23 commits into from
Oct 4, 2019

Conversation

Jikstra
Copy link
Contributor

@Jikstra Jikstra commented Oct 3, 2019

  • Reworks emoji picker and implements stickers
    • For testing you can send any telegram sticker pack to the @Stickerdownloadbot, download the png version and unpack it's *.png files into ~/.config/DeltaChat/<yourid>/stickers/<somestickerpackname>.
  • Refactors Composer, changes onMouseHover behaviour to 'you need to click on emoji picker to open, click somewhere else to close'
  • Applies a new and more sane folder structure to src/renderer and scss (one more part of moving styled components to sass). For example we now group components/scss by message, chat, contact...

@Jikstra Jikstra force-pushed the feat_stickers branch 2 times, most recently from a73d4e4 to 432575f Compare October 3, 2019 09:37
@Simon-Laux
Copy link
Member

Simon-Laux commented Oct 4, 2019

Can you re-add the emoji searchbar?
And make the emoji category selector bigger?

@Simon-Laux
Copy link
Member

what are those .scss.kate-swp files like scss/._global.scss.kate-swp?

@Jikstra
Copy link
Contributor Author

Jikstra commented Oct 4, 2019

Can you re-add the emoji searchbar? And make the emoji category selector bigger?

Yup but not before we merged the other 2prs into this one. But why do you want to have a search bar for emojis? I don't really see the feature in it.

what are those .scss.kate-swp files like scss/._global.scss.kate-swp?

Temp files of the kate editor. Will remove them when we merged the other 2 prs into this one, otherwise things explode

@Jikstra
Copy link
Contributor Author

Jikstra commented Oct 4, 2019

This pr will make the messagelist a bit worse because we're not scrolling down anymore when we're reading a message. Didn't fix it yet because i would like to implement a new messagelist right away.

@Simon-Laux
Copy link
Member

Simon-Laux commented Oct 4, 2019

emoji search by text is useful, sometimes it is quicker to search via English text than looking for a specific emoji in all categories...
Other apps do the search differently over : + searchterm in the composer than they show a popup of the reults where you can choose the right one.
2019-10-04_16-29

@r10s
Copy link
Member

r10s commented Oct 4, 2019

emoji search by text is useful, sometimes it is quicker to search via English text than looking for a specific emoji in all categories...
Other apps do the search differently over : + searchterm in the composer than they show a popup of the reults where you can choose the right one.

yip, it is useful for some users sometimes.

but i would also regard that as a power-feature we can target later. for now, the search bar stands in our way while refactoring the emoji/sticker-picker, so we decided to remove it for now.

@Simon-Laux Simon-Laux merged commit 0983928 into master Oct 4, 2019
@Simon-Laux Simon-Laux deleted the feat_stickers branch January 27, 2020 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants